Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid repeatedly warning about too many figures open. #16314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 24, 2020

Warning once is useful, but no need to warn again if the user
further creates even more figure later in their code (see e.g.
tutorials/intermediate/constrainedlayout_guide.py which spams the
terminal with such warnings).

(Yes, the warning would still get reemitted if the user closes some
windows and then goes again above the limit -- that's less of an issue
and not really worth working around IMO.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Warning once is useful, but no need to warn again if the user
further creates even more figure later in their code (see e.g.
tutorials/intermediate/constrainedlayout_guide.py which spams the
terminal with such warnings).

(Yes, the warning would still get reemitted if the user closes some
windows and then goes again above the limit -- that's less of an issue
and not really worth working around IMO.)
@timhoffm timhoffm added this to the v3.3.0 milestone Jan 24, 2020
@timhoffm timhoffm merged commit 71a54ac into matplotlib:master Jan 24, 2020
@anntzer anntzer deleted the maxopen branch January 24, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants