Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Document animation HTML writer. #16333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2020
Merged

Document animation HTML writer. #16333

merged 1 commit into from
Jan 26, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 26, 2020

Just like all animation writers, it needs to be whitelisted in
missing-references.json due to the way animation_api.rst uses
autosummary.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Jan 26, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a single-sentence description to the docstring of HTMLWriter, without that the docs render badly:

grafik

@anntzer
Copy link
Contributor Author

anntzer commented Jan 26, 2020

sure

@anntzer
Document animation HTML writer.
d29b3d1 
Just like all animation writers, it needs to be whitelisted in
missing-references.json due to the way animation_api.rst uses
autosummary.
@timhoffm timhoffm added this to the v3.3.0 milestone Jan 26, 2020
@timhoffm timhoffm merged commit d500923 into matplotlib:master Jan 26, 2020
@anntzer anntzer deleted the htmlw branch January 26, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation topic: animation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @timhoffm