Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backport PR #16379 on branch v2.2.x (FIX: catch on message content, not module) #16381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

Backport PR #16379 on branch v2.2.x (FIX: catch on message content, not module) #16381

merged 1 commit into from
Jan 31, 2020

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #16379: FIX: catch on message content, not module

@lumberbot-app lumberbot-app bot added this to the v2.2.5 milestone Jan 31, 2020
@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #16381 into v2.2.x will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v2.2.x   #16381      +/-   ##
==========================================
- Coverage   74.16%   72.91%   -1.26%     
==========================================
  Files         284      284              
  Lines       73393    73393              
  Branches    10427    10427              
==========================================
- Hits        54432    53511     -921     
- Misses      16086    17097    +1011     
+ Partials     2875     2785      -90
Impacted Files Coverage Δ
lib/matplotlib/backends/backend_qt4.py 0.00% <0.00%> (-100.00%) ⬇️
lib/matplotlib/backends/qt_editor/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...b/matplotlib/backends/qt_editor/formsubplottool.py 0.00% <0.00%> (-100.00%) ⬇️
lib/matplotlib/tests/test_backend_qt5.py 15.85% <0.00%> (-78.05%) ⬇️
lib/matplotlib/backends/backend_qt5agg.py 0.00% <0.00%> (-71.19%) ⬇️
lib/matplotlib/backends/backend_qt5cairo.py 0.00% <0.00%> (-59.46%) ⬇️
lib/matplotlib/backends/qt_editor/formlayout.py 0.00% <0.00%> (-57.29%) ⬇️
lib/matplotlib/backends/backend_qt5.py 0.00% <0.00%> (-50.00%) ⬇️
lib/matplotlib/backends/qt_editor/figureoptions.py 0.00% <0.00%> (-47.80%) ⬇️
lib/matplotlib/tests/test_backend_qt4.py 28.57% <0.00%> (-28.58%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0cdf97...1652994. Read the comment docs.

@jklymak
Copy link
Member

jklymak commented Jan 31, 2020

Travis Error is MacOS just not building for some reason. Merging as I don't see it has anything to do w/ this PR

@jklymak jklymak merged commit 6f0a313 into matplotlib:v2.2.x Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @jklymak @story645