Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't import rcParams but rather use mpl.rcParams. #16406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2020
Merged

Don't import rcParams but rather use mpl.rcParams. #16406

merged 1 commit into from
Feb 4, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 4, 2020

This helps letting modules be imported early in the init process, even
before the rcParams object is constructed.

I didn't change all cases, just those needed to make matplotlib.scale
importable into matplotlib.colors (per #16386).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Don't import rcParams but rather use mpl.rcParams.
f038112 
This helps letting modules be imported early in the init process, even
before the rcParams object is constructed.

I didn't change all cases, just those needed to make matplotlib.scale
importable into matplotlib.colors.
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #16406 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16406      +/-   ##
==========================================
- Coverage   80.85%   80.85%   -0.01%     
==========================================
  Files         307      307              
  Lines       75745    75748       +3     
  Branches     9690     9691       +1     
==========================================
+ Hits        61245    61246       +1     
- Misses      11961    11962       +1     
- Partials     2539     2540       +1
Impacted Files Coverage Δ
lib/matplotlib/__init__.py 67.18% <0.00%> (-0.18%) ⬇️
lib/matplotlib/spines.py 70.45% <0.00%> (-0.10%) ⬇️
lib/matplotlib/pyplot.py 72.86% <0.00%> (-0.04%) ⬇️
lib/matplotlib/cbook/__init__.py 76.87% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47fc9d...f038112. Read the comment docs.

jklymak
jklymak approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good start on this to me.

@timhoffm timhoffm added this to the v3.3.0 milestone Feb 4, 2020
@timhoffm timhoffm merged commit c198e65 into matplotlib:master Feb 4, 2020
@timhoffm timhoffm mentioned this pull request Feb 4, 2020
Closed
13 tasks
@anntzer anntzer deleted the rcimport branch February 4, 2020 22:59
@timhoffm timhoffm mentioned this pull request Feb 16, 2020
Merged
@anntzer anntzer mentioned this pull request Mar 5, 2020
Merged
6 tasks
@timhoffm timhoffm mentioned this pull request Mar 15, 2020
Merged
@timhoffm timhoffm mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm