Deprecate avconv animation writers. #16408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See changelog. (avconv was a fork of ffmpeg which has kept the same CLI, so the ffmpeg writers are good enough anyways.)
Codecov Report
@@ Coverage Diff @@
## master #16408 +/- ##
==========================================
- Coverage 80.85% 74.85% -6.00%
==========================================
Files 307 276 -31
Lines 75746 68658 -7088
Branches 9691 9688 -3
==========================================
- Hits 61244 51394 -9850
- Misses 11962 14909 +2947
+ Partials 2540 2355 -185
Continue to review full report at Codecov.
|
jklymak
approved these changes
Feb 4, 2020
|
I think you are getting hit w/ the codecov posts because Travis is taking so long. I wonder if we can set codecov to wait longer? |
timhoffm
approved these changes
Feb 4, 2020
|
@jklymak Looks like pillow is experimenting the same issue with codecov per https://community.codecov.io/t/prs-are-commented-even-with-comment-off/941; I'll see if anything shows up on that thread. |
|
Yes, or remove a lot of the redundant testing on Travis now that a lot of it is on azure? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog. (avconv was a fork of ffmpeg which has kept the same
CLI, so the ffmpeg writers are good enough anyways.)
PR Summary
PR Checklist