Remove unnecessary calls to np.array in examples. #16430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's many places where explicit conversion to np.array is not necessary -- because matplotlib or numpy already handles the conversion, or because the variable is already an array. Removing these calls makes the examples concentrate more on the plotting-relevant parts.
Codecov Report
@@ Coverage Diff @@
## master #16430 +/- ##
==========================================
- Coverage 80.86% 74.85% -6.01%
==========================================
Files 307 276 -31
Lines 75749 68660 -7089
Branches 9692 9688 -4
==========================================
- Hits 61252 51395 -9857
- Misses 11959 14909 +2950
+ Partials 2538 2356 -182
Continue to review full report at Codecov.
|
timhoffm
approved these changes
Feb 7, 2020
| @@ -30,7 +30,7 @@ | |||
| ]) | |||
|
|
|||
|
|
|||
| x, y = np.dot(R, np.array([x, y])) | |||
| x, y = np.dot(R, [x, y]) | |||
There was a problem hiding this comment.
Suggested change
| x, y = np.dot(R, [x, y]) | |
| x, y = R @ [x, y] |
Simpler?
There was a problem hiding this comment.
I'd rather leave the dot -> @ for another time.
|
The travis OSX failure looks un-related (failure to read a png back in). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's many places where explicit conversion to np.array is not necessary
-- because matplotlib or numpy already handles the conversion, or
because the variable is already an array. Removing these calls makes
the examples concentrate more on the plotting-relevant parts.
PR Summary
PR Checklist