Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use pytest.raises(match=...) #16454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

Use pytest.raises(match=...) #16454

merged 1 commit into from
Feb 10, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Feb 9, 2020

PR Summary

Use pytest.raises(match=...) instead of catching the excinfo and matching on that.

I've checked that is is available in the minimal pytest version we require (3.6).

@timhoffm timhoffm added this to the v3.3.0 milestone Feb 9, 2020
anntzer
anntzer approved these changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-ci

@tacaswell tacaswell merged commit b583623 into matplotlib:master Feb 10, 2020
@tacaswell
Copy link
Member

Pandas is in the process of putting match= on all of their raises tests

@timhoffm timhoffm deleted the pytest-raises branch February 10, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Maintenance topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @tacaswell @story645 @anntzer