Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Re-phrase doc for bottom kwarg to hist #16480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2020
Merged

Re-phrase doc for bottom kwarg to hist #16480

merged 1 commit into from
Feb 13, 2020

Conversation

dstansby
Copy link
Member

Fixes #16478 - @torokati44, do you think this is clearer?

@dstansby dstansby added this to the 3.2-doc milestone Feb 12, 2020
tacaswell
tacaswell approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should give the OP time to comment, but looks good to me.

@torokati44
Copy link

Yes, it's better, thank you!

@torokati44 torokati44 mentioned this pull request Feb 13, 2020
Closed
@jklymak
Copy link
Member

jklymak commented Feb 13, 2020

CI seems to have hung up, but I'll merge because I think thats just CI and not this PR.

@jklymak jklymak merged commit 7758ad7 into matplotlib:master Feb 13, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 13, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 7758ad7a9e989b2b3afd23641d5eaf2693ee1cfa
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16480: Re-phrase doc for bottom kwarg to hist'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16480-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16480 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

timhoffm pushed a commit to timhoffm/matplotlib that referenced this pull request Feb 16, 2020
@jklymak @timhoffm
Backport PR matplotlib#16480: Re-phrase doc for bottom kwarg to hist
c43aea6
@timhoffm timhoffm mentioned this pull request Feb 16, 2020
Merged
timhoffm added a commit that referenced this pull request Feb 16, 2020
@timhoffm
Merge pull request #16526 from timhoffm/auto-backport-of-pr-16480-on-…
0900819 
…v3.2.x

Backport PR #16480 on v.3.2.x: Re-phrase doc for bottom kwarg to hist
@QuLogic QuLogic modified the milestones: 3.2-doc, v3.2.0 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

The bottom parameter of plt.hist() shifts the data as well, not just the baseline
5 participants
@dstansby @torokati44 @jklymak @tacaswell @QuLogic