Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve test failure messages on warnings. #16528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 16, 2020

When a test fails due to a warning, this improves the failure message
from assert 1 == 0 where 1 = len(WarningsChecker(record=True)) to the
actual warning message.

See e.g. #16509 (comment).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

When a test fails due to a warning, this improves the failure message
from `assert 1 == 0 where 1 = len(WarningsChecker(record=True))` to the
actual warning message.
@anntzer anntzer added this to the v3.3.0 milestone Feb 16, 2020
@anntzer anntzer mentioned this pull request Feb 16, 2020
6 tasks
@tacaswell
Copy link
Member

The test coverage change looks like it is due to the upload from appveyor failing.

@tacaswell tacaswell merged commit d97d67d into matplotlib:master Feb 16, 2020
@anntzer anntzer deleted the failwarn branch February 16, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants