Merge pull request #16404 from jklymak/fix-add-base-symlognorm#16541
Merged
jklymak merged 4 commits intomatplotlib:v3.2.xfrom Feb 21, 2020
Merged
Merge pull request #16404 from jklymak/fix-add-base-symlognorm#16541jklymak merged 4 commits intomatplotlib:v3.2.xfrom
jklymak merged 4 commits intomatplotlib:v3.2.xfrom
Conversation
FIX: add base kwarg to symlognor
Conflicts:
doc/api/next_api_changes/behaviour.rst
- moved to
doc/api/prev_api_changes/api_changes_3.2.0/behavior.rst and re-worded.
lib/matplotlib/colors.py
- implicitly backported converting the docstring to numpy
doc style. Re-worded new docstring
Member
|
If that's a backport, it be merged. |
Member
Author
|
I changed the wording a bit so even though this is a backport, it should be reviewed as a normal PR. |
QuLogic
reviewed
Feb 19, 2020
Member
QuLogic
left a comment
There was a problem hiding this comment.
Since there are some changes, here are a few suggestions.
lib/matplotlib/colors.py
Outdated
| half of the linear range. For example, when *linscale* == 1.0 | ||
| (the default), the space used for the positive and negative halves | ||
| of the linear range will be equal to a decade in the logarithmic | ||
| range if ``base=10``. |
Member
There was a problem hiding this comment.
A small tweak (to the original) for the example sentence, but instead of "When x, then y, if z", it'd be better to put the conditions together as "When x and z, then y."
lib/matplotlib/colors.py
Outdated
Comment on lines
+1229
to
+1230
| If not given, defaults to ``np.e``, consistent with prior | ||
| behavior and warns. |
Member
There was a problem hiding this comment.
The parenthetical is a bit confusing, perhaps:
Suggested change
| If not given, defaults to ``np.e``, consistent with prior | |
| behavior and warns. | |
| If not given, defaults to ``np.e`` (consistent with prior behavior), and warns. |
Co-Authored-By: Elliott Sales de Andrade <[email protected]>
Co-Authored-By: Elliott Sales de Andrade <[email protected]>
jklymak
approved these changes
Feb 21, 2020
Member
|
Should some of these suggestions be pulled forward into master? |
Member
Author
|
@jklymak Yes, I'll take care of that when I merge 3.2.x up to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX: add base kwarg to symlognor
Conflicts:
doc/api/next_api_changes/behaviour.rst
- moved to
doc/api/prev_api_changes/api_changes_3.2.0/behavior.rst and re-worded.
lib/matplotlib/colors.py
- implicitly backported converting the docstring to numpy
doc style. Re-worded new docstring
PR Summary
PR Checklist