Use rc() less often in examples/tutorials. #16578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user learns rcParams.update / dict.update, they'll know how to merge any dicts, whereas rc() is a matplotlib-specific API which is hardly shorter (and needing star-unpacking in the case of tutorials/text/usetex.py, which makes things worse overall). Also it's often better to just pass the argument to the single function call (`text(..., usetex=True)`, `imshow(..., origin="lower")`) which avoids unnecessarily touching global state.
timhoffm
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user learns rcParams.update / dict.update, they'll know how to
merge any dicts, whereas rc() is a matplotlib-specific API which is
hardly shorter (and needing star-unpacking in the case of
tutorials/text/usetex.py, which makes things worse overall).
Also it's often better to just pass the argument to the single
function call (
text(..., usetex=True),imshow(..., origin="lower"))which avoids unnecessarily touching global state.
PR Summary
PR Checklist