Fix _preprocess_data for Py3.9. #16585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Py3.9 BoundArguments becomes a plain dict, so move_to_end doesn't exist anymore and the whole thing crashes with an AttributeError. (Travis currently fails the Py3.9 run.) As it turns out there's a simpler implementation of the whole thing anyways, one can just take whatever args/kwargs were explicitly passed in and, if "label" needs to be added, always add it to kwargs.
tacaswell
approved these changes
Feb 28, 2020
|
CI is passed, but the webhooks got lost 🤷♀️ |
QuLogic
approved these changes
Mar 1, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 1, 2020
timhoffm
added a commit
that referenced
this pull request
Mar 1, 2020
…585-on-v3.2.x Backport PR #16585 on branch v3.2.x (Fix _preprocess_data for Py3.9.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Py3.9 BoundArguments becomes a plain dict, so move_to_end doesn't
exist anymore and the whole thing crashes with an AttributeError.
(Travis currently fails the Py3.9 run.)
As it turns out there's a simpler implementation of the whole thing
anyways, one can just take whatever args/kwargs were explicitly passed
in and, if "label" needs to be added, always add it to kwargs.
May make sense to backport to mpl3.2?
PR Summary
PR Checklist