Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Small unrelated cleanups. #16601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Small unrelated cleanups. #16601

merged 1 commit into from
Mar 10, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 28, 2020

  • In missing_references.py, splitting on ":" will work even if ":" is
    not in the string.
  • Just a linewrap in backend_pdf.
  • In backend_ps, we can just printout the whole psDefs in a single shot.
    (the few extra spaces not stripped out don't affect the validity of
    the PS file and if we really worry about the tiny impact on the file
    size we should just pre-strip the contents of psDefs).
  • rcsetup.validate_sketch is really just validating that its input is
    None or three floats.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Feb 28, 2020
@anntzer
Small unrelated cleanups.
29ec269 
- In missing_references.py, splitting on ":" will work even if ":" is
  not in the string.
- Just a linewrap in backend_pdf.
- In backend_ps, we can just printout the whole psDefs in a single shot.
  (the few extra spaces not stripped out don't affect the validity of
  the PS file and if we *really* worry about the tiny impact on the file
  size we should just pre-strip the contents of psDefs).
- rcsetup.validate_sketch is really just validating that its input is
  None or three floats.
@QuLogic QuLogic merged commit 2df1c54 into matplotlib:master Mar 10, 2020
@anntzer anntzer deleted the cleanup branch March 10, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @QuLogic