Deprecate more rc validators. #16604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we'd make it private and I'd anyways rather add machinery so that
one can just specify it as
[bool, None]
(orOptional[bool]
) in_prop_validators.
period.
a third-party animation writer, because that third-party module
will necessarily first import matplotlib before being able to
register its writer, and thus the matplotlibrc file will be parsed
before the writer is registered. In any case,
MovieWriterRegistry.__getitem__
also raises an informative erroron unknown writer names, which should be enough, so let's just
accept any string.
PR Summary
PR Checklist