Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix overindented lines. #16619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix overindented lines. #16619

merged 1 commit into from
Mar 11, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 1, 2020

This is basically pycodestyle's E127 check, except that pycodestyle is
incorrectly too strict in a few places so we can't enforce it
automatically.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 1, 2020
timhoffm
timhoffm approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically pycodestyle's E127 check, except that pycodestyle is
incorrectly too strict in a few places so we can't enforce it
automatically.

Is that something we should report upstream?

@anntzer
Copy link
Contributor Author

anntzer commented Mar 1, 2020

I have already two PRs open against pycodestyle to fix that.

QuLogic
QuLogic approved these changes Mar 10, 2020
View reviewed changes
@anntzer
Fix overindented lines.
c664fb0 
This is basically pycodestyle's E127 check, except that pycodestyle is
incorrectly too strict in a few places so we can't enforce it
automatically.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 10, 2020

both handled, thanks for the review

@QuLogic QuLogic merged commit 3ea8522 into matplotlib:master Mar 11, 2020
@anntzer anntzer deleted the e127 branch March 11, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm