Tutorials: make path/URL option clearer in matplotlibrc tutorial #16653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Mar 6, 2020
…roductory/customizing.py Co-Authored-By: Tim Hoffmann <[email protected]>
make style.use() example consistent with path
…ing.py change language to improve readability of mpl_configdir section
|
It seems that the codecov/project/tests is still failing; I'm not sure what to make of its output. Are there any guidelines for how to get started handling that failed test? |
|
The codecov test has become flaky but we do not understand why yet (I think it has to do with uploads from some of the CI services being a bit flaky?). It is OK to ignore that in this case (as you clearly have not changed anything that could have changed the tests!). |
|
Is any more action needed from me to close this PR? |
timhoffm
approved these changes
Mar 6, 2020
|
Thanks and congratulations to your first contribution to Matplotlib! We hope to see you back. |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I recently noticed that the tutorial explaining how to create custom matplotlib styles mentions that the
style.use()function can take a path or URL as an argument. This is a very useful feature; I've suggested changes to try to make this more apparent.This PR is to request review of the proposed changes.
PR Checklist