Make test_imagegrid_cbar_mode_edge less flaky. #16656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Mar 4, 2020
anntzer
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Feel free to merge with or without tim's suggestion.
It may make sense to add some machinery in image_comparison to check whether it's overwriting itself? (not in a "controlled" case like here after the PR when the same file is listed twice, but rather in a case where it doesn't expect such an overwrite and is likely due to parametrization) Not sure how complex this would be to implement, and therefore whether it's worth the trouble...
Since parametrizing the test allows it to run in parallel, this makes it flaky, as one process can overwrite the test result image of another. Our standard way for dealing with tests that use the same baseline image is to pass duplicate filenames to `image_comparison`, because that is serialized.
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 7, 2020
QuLogic
added a commit
that referenced
this pull request
Mar 7, 2020
…656-on-v3.2.x Backport PR #16656 on branch v3.2.x (Make test_imagegrid_cbar_mode_edge less flaky.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Since parametrizing the test allows it to run in parallel, this makes it flaky, as one process can overwrite the test result image of another.
Our standard way for dealing with tests that use the same baseline image is to pass duplicate filenames to
image_comparison, because that is serialized.PR Checklist