Update CircleCI and add direct artifact link #16672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CircleCI changed their artifact layout, so our printed link in the build log no longer works. Instead of figuring out how to fix it, switch to a GitHub Action that is able to post the link as a PR status. This is easier to find, and probably easier for them to keep up-to-date.
tacaswell
approved these changes
Mar 6, 2020
timhoffm
approved these changes
Mar 6, 2020
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
@tacaswell this milestone should backport to |
|
We can also manage that my merging v3.2.0-doc into v3.2.x. We have done it both ways in the past, not sure which way is better. |
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 13, 2020
tacaswell
added a commit
that referenced
this pull request
Mar 14, 2020
…3.2.0-doc Backport PR #16672 on branch v3.2.0-doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI is turning on Pipelines next week. @tacaswell flipped the switch, but they also say to update the version in the config file (to be able use new stuff), which is done here. In Cartopy, I tried to convert to their new reusable config format, but it didn't really have much benefit, so I didn't bother here.
Additionally, I dropped the printing of the link to the documentation in the build, because it stopped working. When you're already on the build page, it's easier to go through the artifacts tab at the top. For a quick link directly from the PR, I've added a GitHub Action that posts a status with the correct link (the Action knows the right way to get the link.) Note, it does note post here yet because the Action is not in this repo, but you can see it if you look at the commit in my repo (Cartopy):
The App (an older version of the Action) is used in, e.g., scikit-learn/scikit-learn#14731 and scipy/scipy#10707.