Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug fix 16583 - resetup.py param xtick.alignment updated to properly validate values #16712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

MuhammadFarooq1234
Copy link
Contributor

@MuhammadFarooq1234 MuhammadFarooq1234 commented Mar 9, 2020

PR Summary

This PR is for 16583. When setting xtick.alignment (rcsetup.py) parameter globally in matplotlib, the xtick.alignment parameter was not validating against the correct possible values. Value Error thrown when any value, valid or not, was set. Now users, can properly set xtick alignment globally using valid values 'center', 'left', or 'right'.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@story645
Copy link
Member

story645 commented Mar 9, 2020

Did you intend to close this pull request?

@QuLogic
Copy link
Member

QuLogic commented Apr 23, 2020

Replaced by #16727.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants