nbagg: Don't send events if manager is disconnected. #16742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs, e.g., when saving figures, as one of the first things `print_figure` does is to remove the figure manager. This does mean that nbagg won't be able to set the wait cursor when saving a file, but before 0944dcb that was not being done, and after, saving was broken, so there's no net loss. Fixes matplotlib#16721.
anntzer
approved these changes
Mar 12, 2020
jklymak
approved these changes
Mar 12, 2020
|
I'll merge with the guilt of no knowing either how to write a test. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 12, 2020
jklymak
added a commit
that referenced
this pull request
Mar 12, 2020
…742-on-v3.2.x Backport PR #16742 on branch v3.2.x (nbagg: Don't send events if manager is disconnected.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This occurs, e.g., when saving figures, as one of the first things
print_figuredoes is to remove the figure manager. This does mean that nbagg won't be able to set the wait cursor when saving a file, but before 0944dcb that was not being done,and after, saving was broken, so there's no net loss.Fixes #16721.
Not sure if there's a way to write a test for this yet.
PR Checklist