Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow numbers to set uvc for all arrows in quiver.set_UVC, fixes #16743 #16745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2020
Merged

Allow numbers to set uvc for all arrows in quiver.set_UVC, fixes #16743 #16745

merged 2 commits into from
Mar 13, 2020

Conversation

maxnoe
Copy link
Contributor

@maxnoe maxnoe commented Mar 12, 2020

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Fix for #16743

@maxnoe maxnoe force-pushed the allow_numbers_quiver_uvc branch from ddc910f to a547f0d Compare March 12, 2020 14:32
@jklymak
Copy link
Member

jklymak commented Mar 12, 2020

This is probably fine, but can you bisect and see why this was failing on 3.2 and what the PR was that made the failing change so we can be sure this wasn't purposeful?

@maxnoe
Copy link
Contributor Author

maxnoe commented Mar 12, 2020

It is this: #14424

@jklymak jklymak requested a review from efiring March 12, 2020 17:14
@jklymak jklymak added this to the v3.2.1 milestone Mar 12, 2020
@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Mar 12, 2020
jklymak
jklymak reviewed Mar 12, 2020
View reviewed changes
@jklymak jklymak merged commit 2789820 into matplotlib:master Mar 13, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 13, 2020
@jklymak @meeseeksmachine
Backport PR matplotlib#16745: Allow numbers to set uvc for all arrows…
7c13fae 
… in quiver.set_UVC, fixes matplotlib#16743
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 13, 2020
Merged
QuLogic added a commit that referenced this pull request Mar 13, 2020
@QuLogic
Merge pull request #16761 from meeseeksmachine/auto-backport-of-pr-16…
ae85a8c 
…745-on-v3.2.x

Backport PR #16745 on branch v3.2.x (Allow numbers to set uvc for all arrows in quiver.set_UVC, fixes #16743)
@maxnoe maxnoe deleted the allow_numbers_quiver_uvc branch March 18, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@jklymak jklymak jklymak approved these changes

@efiring efiring Awaiting requested review from efiring

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@maxnoe @jklymak @tacaswell