Cleanup axes_divider examples. #16775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Mar 14, 2020
- Merge simple_axes_divider1 and 2 (there's some duplicated code but factoring that into a function probably won't help readability; at least putting everything in a single file makes it easier to compare the two). - Use `add_axes(..., axes_locator=...)` instead of a separate call to `set_axes_locator()`. (Technically, this means demo_fixed_size_axes now creates a plain Axes instead of an axes_grid1 Axes, but that's not what the example is about, so heh.) - Minor rewording, add a show().
timhoffm
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge simple_axes_divider1 and 2 (there's some duplicated code but
factoring that into a function probably won't help readability; at
least putting everything in a single file makes it easier to compare
the two).
Use
add_axes(..., axes_locator=...)instead of a separate call toset_axes_locator(). (Technically, this means demo_fixed_size_axesnow creates a plain Axes instead of an axes_grid1 Axes, but that's not
what the example is about, so heh.)
Minor rewording, add a show().
PR Summary
PR Checklist