Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added QtGui.QMainWindow.closeEvent() to make sure the close event#1678

Merged
dmcdougall merged 2 commits intomatplotlib:masterfrom
tacaswell:qt4_closeevent
Jan 18, 2013
Merged

added QtGui.QMainWindow.closeEvent() to make sure the close event#1678
dmcdougall merged 2 commits intomatplotlib:masterfrom
tacaswell:qt4_closeevent

Conversation

@tacaswell
Copy link
Copy Markdown
Member

@tacaswell tacaswell commented Jan 17, 2013

cascades closeEvents up properly.

issue #1676

I am not sure if there is a testable issue that shows up with out this patch, but this my understanding of good practice when over-riding functions in sub-classed QT classes.

I will look for any issues that show up without this.

@dmcdougall
Copy link
Copy Markdown
Member

dmcdougall commented Jan 17, 2013

Hmmm. On master my test_bbox_inches tests pass, but with your patch one of them fails. This is locally. Strange.

Edit: And it's the same diff as we remarked here

dmcdougall
dmcdougall reviewed Jan 18, 2013
View reviewed changes
Comment thread lib/matplotlib/backends/backend_qt4.py Outdated
Copy link
Copy Markdown
Member

@dmcdougall dmcdougall Jan 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PEP8 compliancy, can you add a space after the comma?

Copy link
Copy Markdown
Member Author

@tacaswell tacaswell Jan 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. That habit has not fully taken yet.

@tacaswell
Copy link
Copy Markdown
Member Author

tacaswell commented Jan 18, 2013

re-based to master (to avoid

On master, I get failures on test_arraw_ptachs.test_fancyarrow.test (1 error, 2 failures) which looks like issues with size of the output images.

I get the exact same failures with this patch.

ERROR: matplotlib.tests.test_arrow_patches.test_fancyarrow.test

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/tcaswell/local_installs/lib/python2.7/site-packages/matplotlib/testing/decorators.py", line 39, in failer
    result = f(*args, **kwargs)
  File "/home/tcaswell/local_installs/lib/python2.7/site-packages/matplotlib/testing/decorators.py", line 148, in do_test
    self._tol, in_decorator=True)
  File "/home/tcaswell/local_installs/lib/python2.7/site-packages/matplotlib/testing/compare.py", line 340, in compare_images
    np.asarray(expectedImage, dtype=np.int))
ValueError: operands could not be broadcast together with shapes (450,800,4) (600,800,4)

@dmcdougall
Copy link
Copy Markdown
Member

dmcdougall commented Jan 18, 2013

@tacaswell Yes, I have reported the issue in #1681, and it's nothing to do with this patch.

I'll merge this now. Thanks.

dmcdougall added a commit that referenced this pull request Jan 18, 2013
@dmcdougall
Merge pull request #1678 from tacaswell/qt4_closeevent
999f1b2 
added QtGui.QMainWindow.closeEvent() to make sure the close event
@dmcdougall dmcdougall merged commit 999f1b2 into matplotlib:master Jan 18, 2013
This was referenced Jan 18, 2013
Closed
Closed
@tacaswell tacaswell deleted the qt4_closeevent branch January 21, 2013 05:27
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Jan 26, 2013
@dmcdougall @tacaswell
Merge pull request matplotlib#1678 from tacaswell/qt4_closeevent
726e67e 
added QtGui.QMainWindow.closeEvent() to make sure the close event
@tacaswell tacaswell mentioned this pull request Jan 26, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tacaswell @dmcdougall