Simplify interactive zoom handling. #16831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
button, list of axes, callback id) into a single dict (
_zoom_info
).so just store it once (under
start_xy
) instead of repeatedly.not axes
) instead oflater checking
self._xypress
.second button is going to get released anyways, so the release_event
for that second button is going to handle the cancellation just fine.
(More specifically, the second button press will throw away the first
zoom and start a new zoom session from the new starting point, and
then the button release will be detected as a zoom cancelled because
<5px.)
PR Summary
PR Checklist