Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Something trivial I found while scrolling around making sure I covered every join/capstyle we allow. Currently,
collections.py
,rcparams.py
, andlines.py
all have their own way of checking whether a cap/join-style is valid (patches.py
uses the code fromlines.py
). These all boil down to acbook._check_in_list
, but some forget to warn that case-insensitivity is deprecated.Since
rcparams.py
seems like the centralized place for checking that parameters are valid, I had them all callrcparams.validate_[cap|join]style()
instead. This correctly warns for deprecated case-insensitivity.PR Checklist