Small cleanups to dviread. #16876
Merged
Small cleanups to dviread. #16876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Mar 23, 2020
QuLogic
approved these changes
Mar 24, 2020
|
rebased |
Don't use variables whose name shadow builtins (`bytes`, `str` -- the latter is actually a bytes instance). Also use a slightly more idiomatic way to iterate over the bytestring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use variables whose name shadow builtins (
bytes,str-- thelatter is actually a bytes instance). Also use a slightly more
idiomatic way to iterate over the bytestring.
PR Summary
PR Checklist