Add test for close_event. #16917
Merged
Add test for close_event. #16917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that a single close_event is triggered when a window is closed. This caught a bug in the gtk3 backends, which used to emit *two* close_events (see comment there; a better fix would be welcome); and another in the wx backends (which emit *no* close_events when the window is closed by pressing "q" -- now fixed).
timhoffm
approved these changes
Mar 26, 2020
QuLogic
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that a single close_event is triggered when a window is closed.
This caught a bug in the gtk3 backends, which used to emit two
close_events (see comment there; a better fix would be welcome); and
another in the wx backends (which emit no close_events when the window
is closed by pressing "q" -- now fixed per #16919 (comment)).
PR Summary
PR Checklist