Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test the macosx backend on Travis. #16923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2020
Merged

Test the macosx backend on Travis. #16923

merged 1 commit into from
Mar 27, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 26, 2020 •
edited
Loading

PR Summary

Split out of #16921.

edit: proof that it worked: https://codecov.io/gh/matplotlib/matplotlib/compare/54b426397c0e7567edaee4f7f77036c2b8569573...a90006151abc353ad26a3ef36895bf0180cd8762/src/lib/matplotlib/backends/backend_macosx.py

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 26, 2020
@anntzer anntzer force-pushed the cimacos branch 2 times, most recently from 50ad39e to a900061 Compare March 26, 2020 21:13
@anntzer
Copy link
Contributor Author

anntzer commented Mar 26, 2020

Let's see whether we can also get coverage for the macosx extension module...

@QuLogic
Copy link
Member

QuLogic commented Mar 27, 2020

It doesn't look like macOS's compiler has what we need for coverage. I think llvm uses a different flag or a different linker to get that to work?

@QuLogic
Copy link
Member

QuLogic commented Mar 27, 2020

Actually, it may be that you need to pass --coverage in LDFLAGS too (which I think should be done on all systems, actually).

@anntzer
Copy link
Contributor Author

anntzer commented Mar 27, 2020

Let's get this part in first, and defer the coverage to another PR; I reverted the change re: coverage.

@anntzer anntzer mentioned this pull request Mar 27, 2020
Merged
6 tasks
dstansby
dstansby approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 when CI passes

@QuLogic QuLogic merged commit d809e01 into matplotlib:master Mar 27, 2020
@anntzer anntzer deleted the cimacos branch March 27, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
GUI: MacOSX topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @dstansby