Improve error for quoted values in matplotlibrc. #16960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Mar 30, 2020
lib/matplotlib/rcsetup.py
Outdated
| if ((s.startswith('"') and s.endswith('"') | ||
| or s.startswith("'") and s.endswith("'")) | ||
| and s[1:-1] in self.valid): | ||
| msg += f"; remove quotes surrounding your string" |
There was a problem hiding this comment.
Suggested change
| msg += f"; remove quotes surrounding your string" | |
| msg += "; remove quotes surrounding your string" |
unneeded.
... as the need for unquoted values in the matplotlibrc is slightly confusing. Also reword the error message to match the one in _check_in_list/_check_getitem.
tacaswell
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as the need for unquoted values in the matplotlibrc is slightly
confusing.
Also reword the error message to match the one in
_check_in_list/_check_getitem.
Closes #16952.
PR Summary
PR Checklist