tk: Don't resize toolbar during resize event. #16970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is already resized by Tk due to its packing mode, and doing it manually causes the window to grow erratically during resize.
tacaswell
approved these changes
Mar 31, 2020
timhoffm
approved these changes
Mar 31, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 31, 2020
tacaswell
added a commit
that referenced
this pull request
Mar 31, 2020
…970-on-v3.2.x Backport PR #16970 on branch v3.2.x (tk: Don't resize toolbar during resize event.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It is already resized by Tk due to its packing mode, and doing it manually causes the window to grow erratically during resize. This came about since #16929 stopped resizing the figure, so it needs to be backported as well.
PR Checklist