Cleanup imshow_extent tutorial. #17001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Apr 1, 2020
| @@ -263,3 +257,6 @@ def generate_imshow_demo_grid(extents, xlim=None, ylim=None): | |||
|
|
|||
| generate_imshow_demo_grid(extents=[None] + extents, | |||
| xlim=(-2, 8), ylim=(-1, 6)) | |||
|
|
|||
There was a problem hiding this comment.
This should be zero or at most one empty line. The two statements are rendered as a standalone code block, and two empty lines is clearly too much:
generate_imshow_demo_grid(extents=[None] + extents,
xlim=(-2, 8), ylim=(-1, 6))
plt.show()
- Move title-setting out to make it hopefully clearer (it's the first row that matters, not the one with `extent=None`). - Define the kwargs to annotate() at a single call site rather than in a separate dict. - Add show() to make the example runnable from the command-line.
timhoffm
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
row that matters, not the one with
extent=None).separate dict.
PR Summary
PR Checklist