Fix AnnotationBbox picking and a bit of cleanup #17002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b857640 to
d6a9827
Compare
anntzer
reviewed
Apr 22, 2020
There is no `textcoords` argument.
d6a9827 to
a0aba95
Compare
If it's drawn once, and then moved directly offscreen (via zoom or pan), then the offset of the box would not be updated, meaning it could be accidentally picked. It's not enough to simply update the location of the box, because children might get picked instead, so disable a pick in `contains` if the annotated point is offscreen, similar to `draw`. Fixes matplotlib#16946.
a0aba95 to
1816036
Compare
timhoffm
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes picking when the
AnnotationBboxgoes out of view, and cleanup some old code.PR Checklist