Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add return field to documentation of 'get_major_ticks' #17019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2020
Merged

Add return field to documentation of 'get_major_ticks' #17019

merged 3 commits into from
Apr 5, 2020

Conversation

vishalBindal
Copy link
Contributor

@vishalBindal vishalBindal commented Apr 3, 2020 •
edited
Loading

PR Summary

The documentation of axis.Axis.get_major_ticks is updated to list its return type, which is a list of Tick objects. Reference is added to the Tick object documentation. See #17015

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@story645 story645 linked an issue Apr 3, 2020 that may be closed by this pull request
get_major_ticks docs missing return type #17015
Closed
timhoffm
timhoffm reviewed Apr 3, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same change should be applied to get_minor_ticks().

@vishalBindal vishalBindal force-pushed the update-major-ticks-docs branch from a867cba to de62c6f Compare April 4, 2020 22:25
@vishalBindal vishalBindal requested a review from timhoffm April 4, 2020 22:41
@timhoffm timhoffm added this to the v3.3.0 milestone Apr 5, 2020
@timhoffm timhoffm merged commit 2327801 into matplotlib:master Apr 5, 2020
@timhoffm
Copy link
Member

timhoffm commented Apr 5, 2020

Thanks, and congratulations on your first contribution to Matplotlib. 👍

@vishalBindal
Copy link
Contributor Author

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

get_major_ticks docs missing return type
2 participants
@vishalBindal @timhoffm