Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP]Removed pyplot.plotting() #17056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SidharthBansal
Copy link
Contributor

PR Summary

Removed pyplot.plotting()

Part of #16181

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm
Copy link
Member

timhoffm commented Apr 7, 2020

Unfortunately, it's not as simple as just removing the function. If it was just removing one line of code, we'd likely done that already 😄.

There's code that generates the docstring.

It's used here in the docs https://matplotlib.org/api/pyplot_summary.html#matplotlib.pyplot.plotting, which is partly redundant with https://matplotlib.org/api/_as_gen/matplotlib.pyplot.html#module-matplotlib.pyplot. This mess has to be cleaned up along the way.

Steps to do (I haven't looked into the details so I might be wrong somewhere. Please check yourself that this makes sense):

  • Check both docs and verify that the latter is equivalent to the former, so that we can drop the function listing exposed via the plotting() docstring.
  • Replace the former by the latter. Ideally, the colors stuff should be moved somewhere else. IMHO it does not belong into the pyplot module docstring. It may also be redundant, but t.b.c.
  • Remove plotting() and the code that populates its docstring.

@SidharthBansal
Copy link
Contributor Author

SidharthBansal commented Apr 7, 2020 via email

@SidharthBansal SidharthBansal changed the title Removed pyplot.plotting() [WIP]Removed pyplot.plotting() Apr 7, 2020
@jklymak jklymak marked this pull request as draft April 14, 2020 15:01
@tacaswell
Copy link
Member

#16181 was merged without plt.plotting() being removed. Combined with this PR being dormant for over 2 years I am going to close this PR.

Thank you for your work even if we did not merge it @SidharthBansal and I hope we hear from you again!

@tacaswell tacaswell closed this Dec 6, 2022
@QuLogic
Copy link
Member

QuLogic commented Dec 6, 2022

pyplot.plotting was removed in #22669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants