Simplify subgridspec example/tutorial.#17057
Merged
timhoffm merged 1 commit intomatplotlib:masterfrom Apr 7, 2020
Merged
Conversation
- Use add_gridspec to construct the gridspec and subgridspec to construct the subgridspec, saving an import. - Use nested loops rather than itertools.product, which is nice but not really the point of the tutorial. - Index gridspecs with two indices rather than a single flat index, again matching "standard" use. - Set spine visiibility to the right value directly, rather than first toggling them all off and then a few on again.
timhoffm
approved these changes
Apr 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
construct the subgridspec, saving an import.
not really the point of the tutorial.
again matching "standard" use.
toggling them all off and then a few on again.
PR Summary
PR Checklist