Simplify and generalize _set_view_from_bbox. #17067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_set_view_from_bbox is called to figure out the new axes limits when the
mouse is released in interactive zoom.
In the common zoom-in case, simplify the code by using
set_x/ybound
which maintains the previously existing axes inversion (if any),
rather than having a bunch of conditions to sort the arguments
correctly before passing them to
set_x/ylim
.In the (more rarely used?) zoom-out case (which is triggered by
right-clicking, and zooms the axes out so that the previous axes
limits fit in the drawn box), use the axis transform directly rather
than just special-casing log-scale; this is necessary to make zoom-out
work for other scales such as logit.
Tiny cleanups to the
len(bbox) == 3
case, which is only used bytoolmanager to implement zoom-by-scroll, but isn't used by the default
toolbar zoom.
Also add a test for this previously untested path.
PR Summary
PR Checklist