Widgets cleanup. #17124
Merged
Widgets cleanup. #17124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly docstring cleanups, but also a small simplification to _SelectorWidget._get_data.
| self._prev_event = event | ||
| return event | ||
|
|
||
| def press(self, event): | ||
| """Button press handler and validator""" | ||
| """Button press handler and validator.""" |
There was a problem hiding this comment.
Might we want to make this an actual sentence like: "Validate and handle a button press."?
There was a problem hiding this comment.
I tend to think of these callbacks as nouns ("it's the event handler for yada yada") rather than verbs ("do this and that") -- after all, users generally use them as "objects" (passing them to mpl_connect) rather than actually calling them.
tacaswell
approved these changes
Apr 13, 2020
QuLogic
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly docstring cleanups, but also a small simplification to
_SelectorWidget._get_data.
PR Summary
PR Checklist