Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Button widget motion callback. #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fix Button widget motion callback. #17133

merged 1 commit into from
Apr 14, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 14, 2020

PR Summary

Button._lastcolor was removed in #17082, but one instance was missed, so the Button was broken. Can be reproduced by using the subplot parameter editor in Tk.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: widgets/UI labels Apr 14, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone Apr 14, 2020
@QuLogic QuLogic requested a review from anntzer April 14, 2020 04:36
@tacaswell
Copy link
Member

🐑 Sorry about that.

anntzer
anntzer approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@anntzer anntzer merged commit f6b8891 into matplotlib:master Apr 14, 2020
@QuLogic QuLogic deleted the fix-button-widget branch April 14, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: widgets/UI
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @tacaswell @anntzer