Deprecate ScalarMappable.check_update and associated machinery. #17166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiring
approved these changes
Apr 17, 2020
It's a rather complex machinery that's ultimately just used by Collection to know whether the alpha array has been updated so that the value-to-rgba mapping needs to be updated. Users can't connect to it to know whether the mapped values have been updated, and they can't even use it to check whether the *alpha* values have been updated because this unsets the marker and thus would mess up Collection's own use of it. For now, just deprecate its public use to ultimately make it private and perhaps replace it later by something less brittle (e.g., normal a normal callback registry).
|
typo fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a rather complex machinery that's ultimately just used by
Collection to know whether the alpha array has been updated so that the
value-to-rgba mapping needs to be updated. Users can't connect to it to
know whether the mapped values have been updated, and they can't even
use it to check whether the alpha values have been updated because
this unsets the marker and thus would mess up Collection's own use of
it. For now, just deprecate its public use to ultimately make it
private and perhaps replace it later by something less brittle (e.g.,
normal a normal callback registry).
PR Summary
PR Checklist