Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Further sync axes_grid colorbars with standard colorbars. #17175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2020
Merged

Further sync axes_grid colorbars with standard colorbars. #17175

merged 1 commit into from
Apr 30, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 17, 2020

Remap the cbid and locator attributes to the ones of standard colorbars.
Move most functionality of CbarAxes to CbarAxesBase, leaving only the
multiple-inheritance part, so that axisartist.axes_grid.CbarAxes can
likewise just limit itself to multiple-inheritance.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Apr 17, 2020
@anntzer anntzer force-pushed the axes_grid-colorbar branch from 004fe48 to bdf2a43 Compare April 17, 2020 18:52
QuLogic
QuLogic reviewed Apr 17, 2020
View reviewed changes
@anntzer anntzer force-pushed the axes_grid-colorbar branch 4 times, most recently from 82af659 to 75c7642 Compare April 20, 2020 22:44
@anntzer
Copy link
Contributor Author

anntzer commented Apr 25, 2020

rebased

@anntzer anntzer force-pushed the axes_grid-colorbar branch from 75c7642 to 17a9572 Compare April 25, 2020 10:38
tacaswell
tacaswell approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, anyone can merge on green.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 30, 2020

rebased

@anntzer anntzer force-pushed the axes_grid-colorbar branch from 17a9572 to 071b185 Compare April 30, 2020 20:12
@anntzer
Further sync axes_grid colorbars with standard colorbars.
1163bf5 
Remap the cbid and locator attributes to the ones of standard colorbars.
Move most functionality of CbarAxes to CbarAxesBase, leaving only the
multiple-inheritance part, so that axisartist.axes_grid.CbarAxes can
likewise just limit itself to multiple-inheritance.
@anntzer anntzer force-pushed the axes_grid-colorbar branch from 071b185 to 1163bf5 Compare April 30, 2020 20:14
@jklymak
Copy link
Member

jklymak commented Apr 30, 2020

At some point we should discuss the status of axes_grid because a lot of these fixes are orthogonal to the goal of bringing the good things about axes_grid into the main library and dropping support for the rest. Maybe thats just my goal, in which case we should be considering working harder to make axes_grid a first class citizen. But working on both projects at the same time seems inefficient.

@anntzer
Copy link
Contributor Author

anntzer commented Apr 30, 2020

Actually, I would argue that making axes_grid colorbars closer to standard colorbars is reducing the later api_changes note (and disruption to end users) that will be needed when axes_grid goes away (as in "you need to change this to that").

@jklymak
Copy link
Member

jklymak commented Apr 30, 2020

Thats fair; there have been lots of other clean ups, I just wanted to check in that we had similar end goals in sight....

@anntzer
Copy link
Contributor Author

anntzer commented Apr 30, 2020

I'm basically trying to bring axes_grid closer to standard matplotlib, which is perhaps less useful than directly implementing the missing parts in mpl, but still helps (I hope) in reducing the distance between them.

@QuLogic QuLogic merged commit cbc6bb2 into matplotlib:master Apr 30, 2020
@anntzer anntzer deleted the axes_grid-colorbar branch April 30, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance topic: color/colorbar topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @tacaswell @QuLogic