Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Inline unsampled-image path; remove renderer kwarg from _check_unsampled_image. #17191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

Inline unsampled-image path; remove renderer kwarg from _check_unsampled_image. #17191

merged 1 commit into from
Apr 28, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 19, 2020

Inlining _draw_unsampled_image makes the parallel between unsampled and
resampled paths much more obvious.

Moving the check of whether the renderer supports option_scale_image()
out of _check_unsampled_image() lets let latter just concentrate on
properties of the image itself, rather than having to look at the
renderer too.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Inline unsampled-image path; remove renderer kwarg from _check_unsamp…
0635bb7 
…led_image.

Inlining _draw_unsampled_image makes the parallel between unsampled and
resampled paths much more obvious.

Moving the check of whether the renderer supports option_scale_image()
out of _check_unsampled_image() lets let latter just concentrate on
properties of the image itself, rather than having to look at the
renderer too.
@anntzer anntzer added this to the v3.3.0 milestone Apr 19, 2020
@tacaswell tacaswell merged commit 6ec39d5 into matplotlib:master Apr 28, 2020
@anntzer anntzer deleted the unsampled-image branch April 28, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance topic: images
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @tacaswell