Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement set_history_buttons for Tk toolbar. #17200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2020
Merged

Implement set_history_buttons for Tk toolbar. #17200

merged 1 commit into from
May 1, 2020

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Apr 20, 2020

PR Summary

This makes the backward/forward buttons change enabled state based on whether there are actually old/new views available.

This depends on #17111 because otherwise self._buttons is not initialized early enough.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.3.0 milestone Apr 20, 2020
anntzer
anntzer reviewed Apr 20, 2020
View reviewed changes
@timhoffm
Copy link
Member

timhoffm commented May 1, 2020

Please rebase to pick up #17111 and make CI pass.

@QuLogic
Implement set_history_buttons for Tk toolbar.
56504fa 
This makes the backward/forward buttons change enabled state based on
whether there are actually old/new views available.
anntzer
anntzer approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge postci

@anntzer anntzer merged commit 5fed060 into matplotlib:master May 1, 2020
@QuLogic QuLogic deleted the tk-history branch May 1, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: tk
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @timhoffm @anntzer