Simplify some axisartist code. #17209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 23, 2020
In a few places, axisartist temporarily sets the transform of an artist to `new_transform = artist.get_transform() + additional_transform` with an originally empty (identity) `additional_transform` and then later adjusts the `additional_transform` by calling `rotate_deg` or `translate` on it, which has the effect of also modifying `new_transform` in place. Instead, directly add the correct `additional_transform` at the site of use.
QuLogic
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few places, axisartist temporarily sets the transform of an artist
to
new_transform = artist.get_transform() + additional_transformwith an originally empty (identity)
additional_transformand thenlater adjusts the
additional_transformby callingrotate_degor
translateon it, which has the effect of also modifyingnew_transformin place. Instead, directly add the correctadditional_transformat the site of use.PR Summary
PR Checklist