Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix missing attribute in _SVGConverter. #17210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix missing attribute in _SVGConverter. #17210

merged 1 commit into from
Apr 22, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 22, 2020

PR Summary

I broke this accidentally in https://github.com/matplotlib/matplotlib/pull/9454/files#diff-3ccb29855c353a5da7c4525f9bed826aL193 (so a while ago already and noone noticed...) and now it's breaking the mplcairo CI :)

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.2.2 milestone Apr 22, 2020
tacaswell
tacaswell approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this going in without a test as it is a bug in the code path raised on an failed test.

@QuLogic QuLogic merged commit 8c8caea into matplotlib:master Apr 22, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Apr 22, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 8c8caea863175ac03a76280d2796ef25c8be9f73
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17210: Fix missing attribute in _SVGConverter.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17210-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #17210 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the svgconv branch April 22, 2020 21:08
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request May 6, 2020
@QuLogic
Merge pull request matplotlib#17210 from anntzer/svgconv
ca714c1 
Fix missing attribute in _SVGConverter.
@QuLogic QuLogic mentioned this pull request May 6, 2020
Merged
QuLogic added a commit that referenced this pull request May 7, 2020
@QuLogic
Merge pull request #17346 from QuLogic/backports
33b5601 
Backport #17084 and #17210 to v3.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic