Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Simplify Annotation and Text bbox drawing. #17220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 22, 2020

Currently Annotation.draw goes through _check_xy to check whether the
annotation should be drawn at all, and then through
_update_position_xytext to position itself. In order to save a single
call to _get_position_xy, it first calls _get_position_xy itself and
then passes it down to the helper functions, making them harder to
follow. Instead, just let _check_xy call _get_position_xy itself (and
even then, this is only needed for some values of annotation_clip), and
likewise for _update_position_xytext (which just becomes a call to
update_positions).

Also a small shortening of Text.update_bbox_position_size.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Currently Annotation.draw goes through _check_xy to check whether the
annotation should be drawn at all, and then through
_update_position_xytext to position itself.  In order to save a single
call to _get_position_xy, it first calls _get_position_xy itself and
then passes it down to the helper functions, making them harder to
follow.  Instead, just let _check_xy call _get_position_xy itself (and
even then, this is only needed for some values of annotation_clip), and
likewise for _update_position_xytext (which just becomes a call to
update_positions).

Also a small shortening of Text.update_bbox_position_size.
@QuLogic QuLogic merged commit 95ada39 into matplotlib:master May 8, 2020
@anntzer anntzer deleted the ann branch May 8, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants