[agg24]: Fix bad pointer arithmetic #17248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array c is an array of value_type[4], and thus its initial pointer cannot be arbitrarily advanced (without causing undefined behaviour). What seems to be desired instead is to consider the _containing_ object as a member of an array and perform arithmetic in _that_ array. This can be done by _first_ computing the pointer to the ambient object.
|
Note that #16975 goes a different way here, possibly a better one. We should probably use that one instead. |
|
Closing this in favour of #16975, which seems like a better fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array c is an array of value_type[4], and thus its initial pointer
cannot be arbitrarily advanced (without causing undefined
behaviour). What seems to be desired instead is to consider the
containing object as a member of an array and perform arithmetic in
that array. This can be done by first computing the pointer to the
ambient object.