Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix rubberband in tk. #17298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2020
Merged

Fix rubberband in tk. #17298

merged 1 commit into from
May 1, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 1, 2020

The deprecation of NavigationToolbar2.release() used the wrong method
name, causing a needed change in NavigationToolbar2Tk to be missed.
Without this PR, zoom boxes are not erased when the mouse is released.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Fix rubberband in tk.
b9b9f37 
The deprecation of NavigationToolbar2.release() used the wrong method
name, causing a needed change in NavigationToolbar2Tk to be missed.
Without this PR, zoom boxes are not erased when the mouse is released.
@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. GUI: tk labels May 1, 2020
@anntzer anntzer added this to the v3.3.0 milestone May 1, 2020
@QuLogic QuLogic merged commit d1be9ad into matplotlib:master May 1, 2020
@anntzer anntzer deleted the tkzoom branch May 2, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: tk Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm