Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make zooming work in qt-embedding example. #17353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

Make zooming work in qt-embedding example. #17353

merged 1 commit into from
May 7, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 7, 2020

Calling set_ylim everytime in _update_canvas breaks interactive zoom.

Closes #17352 (see description there).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v3.3.0 milestone May 7, 2020
tacaswell
tacaswell reviewed May 7, 2020
View reviewed changes
tacaswell
tacaswell reviewed May 7, 2020
View reviewed changes
@tacaswell
Copy link
Member

I have a slight preference for not user ax.lines[0], but fine either way.

Anyone can merge on the doc build going green.

@tacaswell tacaswell mentioned this pull request May 7, 2020
Closed
@anntzer
Make zooming work in qt-embedding example.
65497d3 
Calling set_ylim everytime in _update_canvas breaks interactive zoom.
@anntzer
Copy link
Contributor Author

anntzer commented May 7, 2020

sure

@QuLogic QuLogic merged commit 9c89f7a into matplotlib:master May 7, 2020
@QuLogic
Copy link
Member

QuLogic commented May 7, 2020 •
edited
Loading

Note this is _sgskip, so the doc build wouldn't care about it, but I tested locally.

@anntzer anntzer deleted the qtex branch May 7, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation GUI: Qt
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Zoom In-Out not behaving as expected in QT backend example
3 participants
@anntzer @tacaswell @QuLogic