Support standard names for freetype hinting flags. #17380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a custom mapping of FreeType hinting flags (FT_LOAD_DEFAULT,
FT_LOAD_NO_AUTOHINT, FT_LOAD_FORCE_AUTOHINT, FT_LOAD_NO_HINTING) to our
own string names ("either", "native", "auto", "default") which is
basically not documented anywhere and makes searching the docs tricky,
*even* when one knows where to look for FreeType flags. Add support for
synonyms which map directly to the standard flag names ("default",
"no_autohint", "force_autohint", "no_hinting") which should at least
make the correspondence more transparent.
There's not much benefit in killing the old synonyms, so I left them in
place.
timhoffm
approved these changes
May 11, 2020
|
I think that's what the PR does? :) |
QuLogic
approved these changes
May 11, 2020
|
@anntzer As I read the description, it does not indicate a preference for the new values (which IMHO it should). |
|
Feel free to pr a rewording :) |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a custom mapping of FreeType hinting flags (FT_LOAD_DEFAULT,
FT_LOAD_NO_AUTOHINT, FT_LOAD_FORCE_AUTOHINT, FT_LOAD_NO_HINTING) to our
own string names ("either", "native", "auto", "default") which is
basically not documented anywhere and makes searching the docs tricky,
even when one knows where to look for FreeType flags. Add support for
synonyms which map directly to the standard flag names ("default",
"no_autohint", "force_autohint", "no_hinting") which should at least
make the correspondence more transparent.
There's not much benefit in killing the old synonyms, so I left them in
place.
PR Summary
PR Checklist