TexManager fixes. #17395
Merged
TexManager fixes. #17395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix calling get_grey with fontsize=None or dpi=None (this would previously just pass the string "None" down the stack and crash). - Fix get_rgba stacking colors and get rid of its cache (the slow part is accessing the filesystem in get_grey, just stacking some colors should be cheap and not caching the result is also nicer memory-wise).
tacaswell
approved these changes
May 13, 2020
|
Should probably add the snippet from #17393 as a test as we apparently don't use this code path otherwise in the testes. |
|
Honestly I'd rather just deprecate get_rgba and add a more generic functionality for combining an alpha map and a given color (as it doesn't really make sense to have that just here), so I don't really want to spend more time on this than strictly needed. But feel free to push one... |
QuLogic
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously just pass the string "None" down the stack and crash).
is accessing the filesystem in get_grey, just stacking some colors
should be cheap and not caching the result is also nicer memory-wise).
Closes #17393.
PR Summary
PR Checklist